Skip to main content

Posts

Showing posts from February, 2020

How to make pull request

PURPOSE Pull requests are a mechanism for a developer to notify team members that they have completed a feature. HOW IT WORKS //============================================== For developer Main step: 1. Make sure branch naming is corrected. Rename command: git branch -m newName 2. Make sure your source code based on lastest source code in "develop" branch git checkout develop git pull git checkout your-branch git rebase resolve conflict(if any) 3.Squash commit A nice way to group some changes together, especially before sharing them with others. https://www.internalpointers.com/post/squash-commits-into-one-git 4. Final step Re-check "Commit message" Re-check "Source changes" Add reviewer //============================================== For reviewer/project maintainer 1. Review code - Convention (naming, format) - Clean code(duplicate, pseudo code, debugger....based on SOLID, DRY, KISS) - Unit test code 2. This implementat