How to make pull request

PURPOSE
Pull requests are a mechanism for a developer to notify team members that they have completed a feature.

HOW IT WORKS
//==============================================
For developer
Main step:
1. Make sure branch naming is corrected.
Rename command:
git branch -m newName

2. Make sure your source code based on lastest source code in "develop" branch

git checkout develop
git pull
git checkout your-branch
git rebase
resolve conflict(if any)

3.Squash commit
A nice way to group some changes together, especially before sharing them with others.
https://www.internalpointers.com/post/squash-commits-into-one-git

4. Final step
Re-check "Commit message"
Re-check "Source changes"
Add reviewer

//==============================================
For reviewer/project maintainer
1. Review code
- Convention (naming, format)
- Clean code(duplicate, pseudo code, debugger....based on SOLID, DRY, KISS)
- Unit test code
2. This implementation is sastisfied requirement or not?
3. Impact to each other module?

//==============================================
If all is good, merge your awesome feature to develop/master branch

Reference:
https://www.atlassian.com/git/tutorials/making-a-pull-request
https://topdev.vn/blog/huong-dan-tao-pull-request-dung-cach/

Comments

[STM32] How to configure Timer 1, Channel 3 is PWM 1kHz, duty cycle 20% to control BLDC motor

To configure Timer1 for a 1 kHz PWM signal with a 20% duty cycle on an STM32H7S3L8 microcontroller, follow these steps: 1. Understand the Timer Parameters PWM Frequency : 1 kHz → Period = 1 ms. Duty Cycle : 20% → ON time = 0.2 ms. The timer’s clock frequency is derived from the APB clock (e.g., TIMCLK). Let’s assume you know the APB clock frequency. The Timer prescaler and auto-reload register (ARR) define the PWM frequency. 2. Compute Timer Parameters Formula: PWM Frequency = Timer Clock (Prescaler + 1) * (ARR + 1) \text{PWM Frequency} = \frac{\text{Timer Clock}}{\text{(Prescaler + 1) * (ARR + 1)}} PWM Frequency = (Prescaler + 1) * (ARR + 1) Timer Clock For 1 kHz PWM: A R R = Timer Clock PWM Frequency ∗ ( Prescaler + 1) − 1 ARR = \frac{\text{Timer Clock}}{\text{PWM Frequency} * (\text{Prescaler + 1)}} - 1 A RR = PWM Frequency ∗ ( Prescaler + 1) Timer Clock −...

[CanadaLife] Example of answers for final test in Smart Service Ontario 2024

If you have failed the final exam in the first attempt. Congratulations, you are not odd. Here, take a look and grab some corrected answers for your next attempt. Don't waste your money and time for more failure. Good luck bros. Quick note: remember that, the system will change the bunch of questions after each attempt. Then your next questionnaire will be different compared with the first trial. ========================================== =============FINAL TEST=================== ========================================== TIP: Here is a list of questions you did not answer correctly. *Please note: You will only be able to view this list immediately following your test attempt. ========================================== Alcohol slows down the central nervous system and impacts how a person thinks, acts, and moves. This means alcohol is a: depressant ========================================== Alcohol is metabolized in the body at a set rate. For most people, that rate is: one...

[MyThought] Software design scalability, how to navigate conflicting perspectives

Your team disagrees on software design scalability. How do you navigate conflicting perspectives? First of all, disagreements usually come from different viewpoints and personal biases. When people look at a problem, they each see it from their own perspective. To make sure everyone’s on the same page, it helps to list out the main issues before jumping into brainstorming. Remember, how scalable the software is will depend on both the project’s budget and timeline. Secondly, based on the project's budget and timeline, team members are encouraged to share their thoughts freely during the brainstorming session. Afterward, we'll gather the most outstanding ideas and compile them into a table of options. We'll then weigh these options based on several criteria, and finally, we'll select the top-ranked one. Moreover, I work in the field of embedded software. Whenever we design a new product, we must consider both the hardware and software aspects. Hardware is always the fir...

Trumpy

Search This Blog